Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(net): IP resolution in docker #10681

Merged
merged 28 commits into from
Sep 11, 2024
Merged

feat(net): IP resolution in docker #10681

merged 28 commits into from
Sep 11, 2024

Conversation

emhane
Copy link
Member

@emhane emhane commented Sep 3, 2024

Enables IP discovery for docker containers that are not connected to the internet, without use of devp2p discovery protocols

@emhane emhane added A-networking Related to networking in general O-docker OS: Docker labels Sep 3, 2024
onbjerg
onbjerg previously requested changes Sep 4, 2024
crates/node/core/src/args/network.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this just be another natresolver variant?

unsure why this should be a different argument

@emhane
Copy link
Member Author

emhane commented Sep 5, 2024

should this just be another natresolver variant?

unsure why this should be a different argument

sure if you like. what should the variant be called?

@emhane emhane requested a review from mattsse September 5, 2024 12:16
@mattsse
Copy link
Collaborator

mattsse commented Sep 5, 2024

perhaps just netif?

@emhane
Copy link
Member Author

emhane commented Sep 5, 2024

Makes sense to tackle integration into NatResolver as sep issue, since changes the signatures of many functions to be able to return error reading os interfaces @mattsse @onbjerg

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion

crates/node/core/src/args/network.rs Outdated Show resolved Hide resolved
crates/node/core/src/args/network.rs Outdated Show resolved Hide resolved
@emhane emhane added this pull request to the merge queue Sep 11, 2024
Merged via the queue into main with commit 6764f7b Sep 11, 2024
35 checks passed
@emhane emhane deleted the emhane/discover-ip-docker branch September 11, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-networking Related to networking in general O-docker OS: Docker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants