optimism: use op-alloy TxDeposit #10667
Conversation
joshieDo
added
C-debt
|
new op-alloy patch out |
tcoratger
requested review from
joshieDo,
Rjected,
mattsse,
fgimenez,
emhane and
gakonst
as code owners
crates/storage/codecs/src/lib.rs
Outdated
| #[cfg(feature = "optimism")] | ||
| use op_alloy_consensus as _; |
There was a problem hiding this comment.
Maybe I missed something with the imports but otherwise it triggers the unused_crate_dependencies clippy (maybe a false positive). I have the impression that since op_alloy_consensus is only used in a submodule under the optimism cfg, it creates this weird warning...
However I thought I did things right in the Cargo.toml with an optional and a dep only for the optimism cfg..
There was a problem hiding this comment.
Imo this is similar to what we have here
crates/primitives/src/lib.rs
Outdated
| #[cfg(feature = "optimism")] | ||
| use reth_codecs as _; |
There was a problem hiding this comment.
why is this now necessary?
| value: self.value, | ||
| gas_limit: self.gas_limit as u64, | ||
| is_system_transaction: self.is_system_transaction, | ||
| input: self.input.clone(), |
There was a problem hiding this comment.
@mattsse currently all Compact impls for alloy transactions clone input during encoding. should we address this with a helper struct?
There was a problem hiding this comment.
I think this is fine because this is Bytes and should be cheap enough
Should close #9484
Waiting for the following inclusion in next op-alloy release:
decode_fieldspub forTxDepositalloy-rs/op-alloy#68TxDepositalloy-rs/op-alloy#69