refactor: move exec metrics into executor #10426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
added
A-execution
onbjerg
force-pushed
the
onbjerg/executor-metrics
branch
3 times, most recently
from
0a2d9b9
to
1f24b9c
Compare
onbjerg
requested review from
rkrasiuk,
shekhirin,
mattsse,
Rjected,
rakita,
fgimenez and
gakonst
as code owners
onbjerg
force-pushed
the
onbjerg/executor-metrics
branch
from
1f24b9c
to
5602fb4
Compare
|
Last task is to update grafana |
probably still needs some noodling to get a nicer unit display
onbjerg
force-pushed
the
onbjerg/executor-metrics
branch
from
b512937
to
1fb9d3f
Compare
mattsse
approved these changes
Sep 3, 2024
Comment on lines
-85
to
-87
| MetricEvent::ExecutionStageGas { gas } => { | ||
| self.sync_metrics.execution_stage.mgas_processed_total.increment(gas / MEGAGAS) | ||
| } |
Comment on lines
+25
to
+28
| pub fn metered<F, R>(&self, input: BlockExecutionInput<'_, BlockWithSenders>, f: F) -> R | ||
| where | ||
| F: FnOnce(BlockExecutionInput<'_, BlockWithSenders>) -> R, | ||
| { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
ExecutionStageMetricsand instead adds anExecutorMetricsused to track things like gas processed, and more in the future.Currently is not integrated into the blockchain tree.
This PR also adds an instantaneous gas/s metric to make this work well with live sync -- currently, if we just added the total gas processed from live sync and did a
ratein Prometheus over it, performance would look abysmal on live sync, since it would divide the gas processed over the entire slot time (12s).I've implemented this with a
meteredfn that takes a closure and measures the relevant metrics from the input and output. This is ok except it does not handle generic inputs.An alternative I've considered (and still am) was adding some metering to the executor traits instead, since it allows us to handle generic inputs and outputs more easily
Future work could include adding metrics for sloads/sstores, bytecode reads/writes, and account loads/updates
Closes #10397 and closes #9863