Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: devmode launcher implementation #10407

Closed
wants to merge 4 commits into from

Conversation

malik672
Copy link
Contributor

closes #10104

@malik672 malik672 marked this pull request as draft August 21, 2024 02:36
@malik672
Copy link
Contributor Author

@mattsse

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all of this should go in a separate file to not pollute the existing code.

I'd even prefer a new crate for now because we need more stuff from the engine crate

name = "reth-engine-tree"

what we need is like an Orchestrator that is a stream that advances the chain by polling the mining mode.
It would actually be great if we could leverage the existing payloadbuilder stack for this and trigger a payload based on the MindingMode

lmk if I should provide step by step instructions

I think first we want a fresh crate for this, then a minimal mining task that is ideally wired with a PayloadBuilderHandle and a miningmode

@malik672
Copy link
Contributor Author

ok, will do that and probably ask for help in the next pr

@malik672
Copy link
Contributor Author

all of this should go in a separate file to not pollute the existing code.

I'd even prefer a new crate for now because we need more stuff from the engine crate

name = "reth-engine-tree"

what we need is like an Orchestrator that is a stream that advances the chain by polling the mining mode. It would actually be great if we could leverage the existing payloadbuilder stack for this and trigger a payload based on the MindingMode

lmk if I should provide step by step instructions

I think first we want a fresh crate for this, then a minimal mining task that is ideally wired with a PayloadBuilderHandle and a miningmode

@mattsse what should i name the new crate ?

@emhane emhane added C-enhancement New feature or request D-complex Quite challenging from either a design or technical perspective Ask for help! labels Aug 21, 2024
@mattsse
Copy link
Collaborator

mattsse commented Aug 22, 2024

maybe dev-node or smth

@malik672
Copy link
Contributor Author

@mattsse can I get some instructions?

@malik672 malik672 requested a review from mattsse August 25, 2024 14:00
@malik672
Copy link
Contributor Author

@mattsse made some new changes

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Sep 22, 2024
@github-actions github-actions bot removed the S-stale This issue/PR is stale and will close with no further activity label Sep 29, 2024
@mattsse
Copy link
Collaborator

mattsse commented Oct 14, 2024

marking as complted via #11703

@mattsse mattsse closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement New feature or request D-complex Quite challenging from either a design or technical perspective Ask for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add devmode launcher implementation
3 participants