-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: devmode launcher implementation #10407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of this should go in a separate file to not pollute the existing code.
I'd even prefer a new crate for now because we need more stuff from the engine crate
reth/crates/engine/tree/Cargo.toml
Line 2 in 1f5fb90
name = "reth-engine-tree" |
what we need is like an Orchestrator
that is a stream that advances the chain by polling the mining mode.
It would actually be great if we could leverage the existing payloadbuilder stack for this and trigger a payload based on the MindingMode
lmk if I should provide step by step instructions
I think first we want a fresh crate for this, then a minimal mining task that is ideally wired with a PayloadBuilderHandle and a miningmode
ok, will do that and probably ask for help in the next pr |
@mattsse what should i name the new crate ? |
maybe dev-node or smth |
@mattsse can I get some instructions? |
@mattsse made some new changes |
marking as complted via #11703 |
closes #10104