Skip to content

Commit

Permalink
clarify why handle events before wal finalization
Browse files Browse the repository at this point in the history
  • Loading branch information
shekhirin committed Sep 27, 2024
1 parent 74810e1 commit 042bea8
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion crates/exex/exex/src/manager.rs
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,8 @@ where
type Output = eyre::Result<()>;

/// Main loop of the [`ExExManager`]. The order of operations is as follows:
/// 1. Handle incoming ExEx events.
/// 1. Handle incoming ExEx events. We do it before finalizing the WAL, because it depends on
/// the latest state of [`ExExEvent::FinishedHeight`] events.
/// 2. Finalize the WAL with the finalized header, if necessary.
/// 3. Drain [`ExExManagerHandle`] notifications, push them to the internal buffer and update
/// the internal buffer capacity.
Expand Down

0 comments on commit 042bea8

Please sign in to comment.