fix

crates/primitives/src/transaction/pooled.rs

@@ -223,6 +223,9 @@ impl PooledTransactionsElement {
             // decode the type byte, only decode BlobTransaction if it is a 4844 transaction
             let tx_type = *data.first().ok_or(RlpError::InputTooShort)?;
 
+            // First, we advance the buffer past the type byte
+            data.advance(1);
+
             if tx_type == EIP4844_TX_TYPE_ID {
                 // Recall that the blob transaction response `TransactionPayload` is encoded like
                 // this: `rlp([tx_payload_body, blobs, commitments, proofs])`
@@ -232,21 +235,17 @@ impl PooledTransactionsElement {
                 //
                 // This makes the full encoding:
                 // `tx_type (0x03) || rlp([[chain_id, nonce, ...], blobs, commitments, proofs])`
-                //
-                // First, we advance the buffer past the type byte
-                data.advance(1);
 
                 // Now, we decode the inner blob transaction:
                 // `rlp([[chain_id, nonce, ...], blobs, commitments, proofs])`
                 let blob_tx = BlobTransaction::decode_inner(data)?;
                 Ok(Self::BlobTransaction(blob_tx))
             } else {
-                // DO NOT advance the buffer for the type, since we want the enveloped decoding to
-                // decode it again and advance the buffer on its own.
-                let typed_tx = TransactionSigned::decode_2718(data).map_err(|err| match err {
-                    Eip2718Error::RlpError(err) => err,
-                    _ => RlpError::Custom("failed to decode EIP-2718 transaction"),
-                })?;
+                let typed_tx =
+                    TransactionSigned::typed_decode(tx_type, data).map_err(|err| match err {
+                        Eip2718Error::RlpError(err) => err,
+                        _ => RlpError::Custom("failed to decode EIP-2718 transaction"),
+                    })?;
 
                 // because we checked the tx type, we can be sure that the transaction is not a
                 // blob transaction or legacy