feat(EIP-7516): BLOBBASEFEE opcode #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
DanielSchiavini
commented
Apr 23, 2024
DanielSchiavini
commented
- Add missing fields to TxEnv
- Add tests
- Add fake_exponential function
- Add set_tx_env method
- Update dependencies
EIP-7516: BLOBBASEFEE opcode
DaniPopes
reviewed
Apr 23, 2024
DaniPopes
approved these changes
Apr 24, 2024
This test was checking the EVM which we don't need to test in this repo.
DanielSchiavini
added a commit
to DanielSchiavini/vyper
that referenced
this pull request
Apr 25, 2024
- Uses new pyrevm version paradigmxyz/pyrevm#16
| address = "0xd8dA6BF26964aF9D7eEd9e03E53415D37aA96045" # vitalik.eth | ||
| address2 = "0xbBbBBBBbbBBBbbbBbbBbbbbBBbBbbbbBbBbbBBbB" | ||
|
|
||
| fork_url = "https://mainnet.infura.io/v3/c60b0bb42f8a4c6481ecd229eddaca27" | ||
| # use your own key during development to avoid rate limiting the CI job | ||
| fork_url = os.getenv("FORK_URL") or "https://mainnet.infura.io/v3/c60b0bb42f8a4c6481ecd229eddaca27" |
There was a problem hiding this comment.
whose key is this and why is it in the codebase?
There was a problem hiding this comment.
This key was here from the beginning, probably from @gakonst - removing it will break unit tests for PRs
There was a problem hiding this comment.
| @@ -0,0 +1,8 @@ | |||
| 61002661000f6000396100266000f35f3560e01c635fb0146d811861001e5734610022574a60405260206040f35b5f5ffd5b5f80fd8418268000a16576797065728300030b0012 | |||
|
|
|||
| Only the first line is read in the tests. This was generated based on the following Vyper code: | |||
There was a problem hiding this comment.
should we add a test for blobhash as well? cf. vyperlang/vyper#3962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.