migrate: ethers to alloy #194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YadominJinta
force-pushed
the
feat/alloy
branch
4 times, most recently
from
415e4c7 to
0466bde
Compare
gakonst
reviewed
Jul 9, 2024
sslivkoff
reviewed
Nov 25, 2024
sslivkoff
reviewed
Nov 25, 2024
YadominJinta
force-pushed
the
feat/alloy
branch
from
34618cf to
8d0c87f
Compare
sslivkoff
reviewed
Dec 5, 2024
sslivkoff
reviewed
Dec 5, 2024
| max_priority_fee_per_gas: Vec<Option<u64>>, | ||
| max_fee_per_gas: Vec<Option<u64>>, | ||
| success: Vec<bool>, | ||
| n_input_bytes: Vec<u32>, | ||
| n_input_zero_bytes: Vec<u32>, | ||
| n_input_nonzero_bytes: Vec<u32>, | ||
| n_rlp_bytes: Vec<u32>, | ||
| // not support by alloy |
There was a problem hiding this comment.
looks like n_rlp_bytes can be achieved by converting Transaction to Signed and using Signed.rlp_encoded_length()
https://docs.rs/alloy/0.6.4/alloy/consensus/struct.Signed.html#method.rlp_encoded_length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
migrate from ethers.rs to alloy
Solution
PR Checklist