filter erc transfers and traces by from/to addresses #123
Conversation
crates/freeze/src/datasets/traces.rs
Outdated
| Action::Call(action) => action.from, | ||
| Action::Create(action) => action.from, | ||
| Action::Suicide(action) => action.address, | ||
| Action::Reward(action) => action.author, |
There was a problem hiding this comment.
Action::Reward(action) => action.author, should be to in the to filter not the from filter
There was a problem hiding this comment.
resolved in 9bad7a5
|
other than that one comment lgtm |
|
actually I just realized something. for erc20 / erc721 transfers, the from_address / to_address are topic1 and topic2 of the log. so they can just be provided as filters to the log request. that will fetch less data and be more simple+efficient overall |
| @@ -37,7 +37,28 @@ impl CollectByBlock for Erc20Transfers { | |||
| let topics = [Some(ValueOrArray::Value(Some(*EVENT_ERC20_TRANSFER))), None, None, None]; | |||
There was a problem hiding this comment.
from_address and to_address are indexed for erc20 and erc721 addresses in topic1 and topic2. so they can go as items in this filter. it will fetch less data and be simpler than filtering
There was a problem hiding this comment.
resolved in 55aa899
|
awesome! great feature |
Motivation
Solves #97.
Solution
For traces, take from/to according to appropriate trace type and compare with given parameters. For ERC transfers, compare appropriate indexed log with given parameters.
PR Checklist