Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme and fix generate strategy in cli #49

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

blacktoast
Copy link

  1. the execution command
cargo run -- --wss <INFURA_OR_ALCHEMY_KEY> --opensea-api-key <OPENSEA_API_KEY> --private-key <PRIVATE_KEY> --arb-contract-address <ARB_CONTRACT_ADDRESS> --bid-percentage <BID_PERCENTAGE>

in the existing readme is not executed.

Currently, there are two folders in the bin folder, so I modified the command to test the opensea sudoswap arbitrage strategy.

  1. When you run the bin cli cargo run --bin cli -- --strategy-name <NAME>, it returns a PANIC error if the folder name already exists.

I wrote logic to create the strategy dir by checking if it is an already existing folder.

  1. Currently, the folder under strategies is named Kebab case and the folder created by the cli is Snake case, so it is not possible to run the existing opensea-sudo-arb.

First, we need to create a
We changed the case to snake -> kebab so that we can run the existing strategy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant