improvements

src/linitd.c

@@ -533,18 +533,23 @@ void cmd_start(struct conn *c, char *args) {
     } else {
         struct service *svc = findService(args);
         if(svc != NULL) {   //service already started
-            if(setNotify(svc, c)) {
-                fprintf(stderr, "Failed to set conn %d to be notified about %s\n", c->fd, args);\
+            if(!setNotify(svc, c)) {
+                fprintf(stderr, "Failed to set conn %d to be notified about %s\n", c->fd, args);
                 close_conn(c);
                 goto end;
             }
             //format: "notify %s %s", args, status
             char not[] = "notify ";
             char *status = statestr(svc->state);
-            char ntxt[strlen(not) + strlen(args) + strlen(status) + 1];
-            memcpy(ntxt, not, strlen(not));
-            memcpy(ntxt + strlen(not), args, strlen(args));
-            memcpy(ntxt + strlen(not) + strlen(args), status, strlen(status));
+            char ntxt[strlen(not) + strlen(args) + strlen(status) + 2];
+            char *nt = ntxt;
+            strcpy(nt, not);
+            nt += strlen(not);
+            strcpy(nt, args);
+            nt += strlen(args);
+            *nt = ' ';
+            nt++;
+            strcpy(nt, status);
             struct buf dat = { .dat = ntxt, .len = strlen(ntxt) + 1 };
             if(notify(c, svc, dat) != notify_success) {
                 fprintf(stderr, "Failed to notify conn %d about the state of %s\n", c->fd, args);

src/scripts/init.d/login.sh

@@ -1,7 +1,7 @@
 #!/etc/rc.common
 
 depends() {
-    dep printk
+    dep pre welcome
 }
 
 start() {

src/scripts/init.d/pre.sh

@@ -0,0 +1,19 @@
+#!/etc/rc.common
+
+#Pre-boot targets
+
+depends() {
+    if [ -d /etc/rc.d/pre ]; then
+        dep $(ls /etc/rc.d/pre)
+    fi
+}
+
+enable() {
+    if [ ! -d /etc/rc.d/pre ]; then
+        mkdir /etc/rc.d/pre
+    fi
+}
+
+disable() {
+    rm -r /etc/rc.d/pre
+}

src/scripts/init.d/printk.sh

@@ -3,3 +3,12 @@
 start() {
     echo 0 > /proc/sys/kernel/printk
 }
+
+enable() {
+    /etc/init.d/pre enable
+    ln -s /etc/init.d/$this /etc/rc.d/pre/$this
+}
+
+disable() {
+    rm /etc/rc.d/pre/$this
+}

src/scripts/init.d/test.sh

@@ -0,0 +1,9 @@
+#!/etc/rc.common
+
+depends() {
+    dep pre
+}
+
+start() {
+    echo 123
+}

src/scripts/init.d/welcome.sh

@@ -1,5 +1,9 @@
 #!/etc/rc.common
 
+depends() {
+    dep pre
+}
+
 start() {
     echo Hello!
 }