golang: allow downloads during instalation of gRPC protobuf plugins (Cherry-pick of #21614) #21856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…21614) As described in #21529, the Go rules are setting `GOPROXY=off` during the invocations of `go install` to install the gRPC protobuf plugins because that is the default for `GoSdkProcess`. The plugin builds are failing because `GOPROXY=off` prevents `go` from contacting the Go module proxy to learn about module deprecations. (Unlike other uses of `GoSdkProcess`, the gRPC protobuf plugins are relying on `go install` to do a full build of the plugin sources, which is unlike the use of `GoSdkProcess` in the rest of the Go backend rules.) Solution: Set `allow_downloads=True` (which is already done for a preceding `go mod download`) to allow `go` to contact the Go module proxy as needed by not setting `GOPROXY=off`. Fixes #21529.
tdyas
approved these changes
Jan 19, 2025
tdyas
added
the
release-notes:not-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #21529, the Go rules are setting
GOPROXY=offduring the invocations ofgo installto install the gRPC protobuf plugins because that is the default forGoSdkProcess. The plugin builds are failing becauseGOPROXY=offpreventsgofrom contacting the Go module proxy to learn about module deprecations. (Unlike other uses ofGoSdkProcess, the gRPC protobuf plugins are relying ongo installto do a full build of the plugin sources, which is unlike the use ofGoSdkProcessin the rest of the Go backend rules.)Solution: Set
allow_downloads=True(which is already done for a precedinggo mod download) to allowgoto contact the Go module proxy as needed by not settingGOPROXY=off.Fixes #21529.