Move the Rust Scope code to its own file. #21825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjyw
commented
Jan 12, 2025
| use super::{DictEdit, OptionsSource}; | ||
| use crate::fromfile::FromfileExpander; | ||
| use crate::parse::Parseable; | ||
| use crate::scope::Scope; |
There was a problem hiding this comment.
I guess we don't have a preferred idiom for use super vs use crate? I prefer the latter as it makes refactoring easier.
tdyas
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I will shortly be adding a "ScopeInfo" type
struct on the Rust side, and piling it on to id.rs
doesn't seem right.
This is just a move of top-level symbols and
their test. No logic changes.