Stuff #194
Merged
Stuff #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpantos
reviewed
Feb 12, 2025
| @@ -8,6 +8,7 @@ | |||
| is_supported_protocol_version as _is_supported_protocol_version_by_common | |||
|
|
|||
| _SUPPORTED_PROTOCOL_VERSIONS: typing.Final[set[semantic_version.Version]] = { | |||
| semantic_version.Version('0.2.0'), | |||
There was a problem hiding this comment.
The current contract on our chains are on 0.2.0. If we make a release this week without updating the contracts, we might potentially break something. Therefore I left it inside to make sure that we are compatible with the current contracts.
juanmanuel-tirado
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
QA Instructions
Please replace this line with instructions on how to test your changes.
[optional] Are there any post deployment tasks we need to perform?