Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added forceAuthn as a configuration setting #291

Closed
wants to merge 1 commit into from

Conversation

Gleydar
Copy link

@Gleydar Gleydar commented Apr 21, 2022

Hi,
I just added a quick and dirty setting for the forceAuthn parameter which has helped me with configuring G-Suite logins using multiple accounts and chrome sign ins.

@Gleydar Gleydar requested a review from a team as a code owner April 21, 2022 14:53
@danielbachhuber danielbachhuber self-requested a review April 25, 2022 11:14
Copy link
Contributor

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, @Gleydar !

Given this is a "quick and dirty setting", I'm not sure it makes sense to add in its current form.

Instead, would you be open to creating a new issue that documents the problem you experienced and solution you found? We can let the solution evolve in the issue thread before we codify it in code.

@Gleydar
Copy link
Author

Gleydar commented Apr 25, 2022

@danielbachhuber Sure, no problem!

Edit: #292 is created

@danielbachhuber
Copy link
Contributor

👍 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants