Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An impossibly large refactor #501

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

winmillwill
Copy link
Member

Includes the build-docker-images branch.

The commits are all distinct and understandable except the last one which is:

  1. introducing typedefs for sdata and pdata to shrink boilerplate
  2. consistently using the const funcname pattern for log messages instead of pasting the name as a string literal everywhere
  3. refactoring filecache_sync to favor early returns over else and goto
  4. refactoring get_fresh_fd to
  • dispatch separate http outcomes to distinct handler functions
  • use newly created reusable _filecache_truncate helper, factored out of filecache_truncate
  • offload cache freshness determination to a helper function
  • similarly favor early return over else and goto
  • fit on a screen

@winmillwill winmillwill force-pushed the an-impossibly-large-refactor branch from 80b504f to dec3070 Compare September 18, 2019 18:41
@pantheon-circleci
Copy link

@pantheon-circleci
Copy link

@djschaap djschaap marked this pull request as draft January 20, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants