Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - remove dead code for popovers #9296

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Conversation

stevector
Copy link
Contributor

@rachelwhitton @jazzsequence I think the sporadic errors we've been seeing in npm run develop relate to this code (that's present in a few templates). I think it might be safe to delete because popover is now coming from the design system instead of from custom code. I'll need to test more. But I'm getting a foothold on the PR so that I can reference it in the nav PR.

@stevector stevector requested a review from a team as a code owner November 8, 2024 22:33
Copy link

github-actions bot commented Nov 8, 2024

Hi from your friendly robot! 🤖

I've applied Prettier formatting to the following files in 75eb0b8:

src/templates/doc.js

The full diff is below. Please review the changes.

Click to expand
diff --git a/src/templates/doc.js b/src/templates/doc.js
index e032ad2a7..5ef53e818 100644
--- a/src/templates/doc.js
+++ b/src/templates/doc.js
@@ -1,25 +1,23 @@
-import React from "react"
-import { graphql } from "gatsby"
+import React from 'react';
+import { graphql } from 'gatsby';
 
-import Layout from "../layout/layout"
-import SEO from "../layout/seo"
-import HeaderBody from "../components/headerBody"
-import TOC from "../components/toc"
-import GetFeedback from "../components/getFeedback"
+import Layout from '../layout/layout';
+import SEO from '../layout/seo';
+import HeaderBody from '../components/headerBody';
+import TOC from '../components/toc';
+import GetFeedback from '../components/getFeedback';
 
-import { Container, SidebarLayout } from "@pantheon-systems/pds-toolkit-react"
-
-import MdxWrapper from "../components/mdxWrapper"
+import { Container, SidebarLayout } from '@pantheon-systems/pds-toolkit-react';
 
+import MdxWrapper from '../components/mdxWrapper';
 
 // Set container width for search and main content.
-const containerWidth = "standard"
+const containerWidth = 'standard';
 
 class DocTemplate extends React.Component {
-
   render() {
-    const node = this.props.data.doc
-    const isoDate = this.props.data.date
+    const node = this.props.data.doc;
+    const isoDate = this.props.data.date;
 
     return (
       <Layout footerBorder>
@@ -27,7 +25,7 @@ class DocTemplate extends React.Component {
           title={node.frontmatter.title}
           description={node.frontmatter.description || node.excerpt}
           authors={node.frontmatter.contributors}
-          image={"/images/assets/default-thumb-doc.png"}
+          image={'/images/assets/default-thumb-doc.png'}
           categories={node.frontmatter.categories}
           keywords={node.frontmatter.tags}
           reviewed={isoDate.frontmatter.reviewed}
@@ -52,9 +50,8 @@ class DocTemplate extends React.Component {
                   isoDate={isoDate.frontmatter.reviewed}
                   cms={node.frontmatter.cms}
                 />
-                <div style={{ marginTop: "15px", marginBottom: "45px" }}>
+                <div style={{ marginTop: '15px', marginBottom: '45px' }}>
                   <MdxWrapper mdx={node.body} />
-
                 </div>
               </article>
               <TOC slot="sidebar" title="Contents" />
@@ -71,11 +68,11 @@ class DocTemplate extends React.Component {
           </Container>
         </main>
       </Layout>
-    )
+    );
   }
 }
 
-export default DocTemplate
+export default DocTemplate;
 
 export const pageQuery = graphql`
   query DocBySlug($slug: String!) {
@@ -113,4 +110,4 @@ export const pageQuery = graphql`
       }
     }
   }
-`
+`;

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9296-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9296-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9296-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9296-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link
Member

@rachelwhitton rachelwhitton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested popovers across the various templates and also ran VRT locally and lgtm :shipit:

screencapture-localhost-9323-2024-11-12-10_16_49 (1)

@stevector
Copy link
Contributor Author

@rachelwhitton great! Can you manually check some pages that you know have popovers?

@stevector
Copy link
Contributor Author

Great! Can you merge?

@rachelwhitton rachelwhitton merged commit c94f76a into main Nov 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants