-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - remove dead code for popovers #9296
Conversation
Hi from your friendly robot! 🤖 I've applied Prettier formatting to the following files in 75eb0b8:
The full diff is below. Please review the changes. Click to expanddiff --git a/src/templates/doc.js b/src/templates/doc.js
index e032ad2a7..5ef53e818 100644
--- a/src/templates/doc.js
+++ b/src/templates/doc.js
@@ -1,25 +1,23 @@
-import React from "react"
-import { graphql } from "gatsby"
+import React from 'react';
+import { graphql } from 'gatsby';
-import Layout from "../layout/layout"
-import SEO from "../layout/seo"
-import HeaderBody from "../components/headerBody"
-import TOC from "../components/toc"
-import GetFeedback from "../components/getFeedback"
+import Layout from '../layout/layout';
+import SEO from '../layout/seo';
+import HeaderBody from '../components/headerBody';
+import TOC from '../components/toc';
+import GetFeedback from '../components/getFeedback';
-import { Container, SidebarLayout } from "@pantheon-systems/pds-toolkit-react"
-
-import MdxWrapper from "../components/mdxWrapper"
+import { Container, SidebarLayout } from '@pantheon-systems/pds-toolkit-react';
+import MdxWrapper from '../components/mdxWrapper';
// Set container width for search and main content.
-const containerWidth = "standard"
+const containerWidth = 'standard';
class DocTemplate extends React.Component {
-
render() {
- const node = this.props.data.doc
- const isoDate = this.props.data.date
+ const node = this.props.data.doc;
+ const isoDate = this.props.data.date;
return (
<Layout footerBorder>
@@ -27,7 +25,7 @@ class DocTemplate extends React.Component {
title={node.frontmatter.title}
description={node.frontmatter.description || node.excerpt}
authors={node.frontmatter.contributors}
- image={"/images/assets/default-thumb-doc.png"}
+ image={'/images/assets/default-thumb-doc.png'}
categories={node.frontmatter.categories}
keywords={node.frontmatter.tags}
reviewed={isoDate.frontmatter.reviewed}
@@ -52,9 +50,8 @@ class DocTemplate extends React.Component {
isoDate={isoDate.frontmatter.reviewed}
cms={node.frontmatter.cms}
/>
- <div style={{ marginTop: "15px", marginBottom: "45px" }}>
+ <div style={{ marginTop: '15px', marginBottom: '45px' }}>
<MdxWrapper mdx={node.body} />
-
</div>
</article>
<TOC slot="sidebar" title="Contents" />
@@ -71,11 +68,11 @@ class DocTemplate extends React.Component {
</Container>
</main>
</Layout>
- )
+ );
}
}
-export default DocTemplate
+export default DocTemplate;
export const pageQuery = graphql`
query DocBySlug($slug: String!) {
@@ -113,4 +110,4 @@ export const pageQuery = graphql`
}
}
}
-`
+`; |
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9296-documentation.appa.pantheon.site |
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9296-documentation.appa.pantheon.site |
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9296-documentation.appa.pantheon.site |
⚡ Deployed with Pantheon Decoupled This build was successfully deployed with Pantheon. You can track the build logs here. 👀 Preview: https://pr-9296-documentation.appa.pantheon.site |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rachelwhitton great! Can you manually check some pages that you know have popovers? |
@stevector yes I tested a few across the various templates like: |
Great! Can you merge? |
@rachelwhitton @jazzsequence I think the sporadic errors we've been seeing in
npm run develop
relate to this code (that's present in a few templates). I think it might be safe to delete because popover is now coming from the design system instead of from custom code. I'll need to test more. But I'm getting a foothold on the PR so that I can reference it in the nav PR.