Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update modules-known-issues.md #8836

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update modules-known-issues.md #8836

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c539023
Update modules-known-issues.md
pete-cleary Jan 23, 2024
ac53ce9
Revert "Update modules-known-issues.md"
rachelwhitton Jun 12, 2024
7112b67
Add known solution for OAuth permissions issue
rachelwhitton Jun 12, 2024
2952bff
Update source/content/modules-known-issues.md
rachelwhitton Jul 11, 2024
d8cf0ee
Update source/content/modules-known-issues.md
rachelwhitton Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions source/content/modules-known-issues.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,10 +395,14 @@ ___
___

## [Simple OAuth / OAuth 2.0](https://www.drupal.org/project/simple_oauth)
<ReviewDate date="2024-06-12" />

**Issue**: The module requires a very specific set of permissions for the folder and the keys to be uploaded. Using Private or non-standard filepaths won't work. It is not possible to change these in LIVE or TEST environment.
**Issue**: This module requires a very specific set of permissions for the folder and the keys to be uploaded.

**Solution**: Apply the following patches (which have been tested and validated by Pantheon), based on your site's PHP version, to solve for this issue:
* [Oauth Permission Patch - Required to resolve Pantheon known issues (PHP 8.0+)](https://patch-diff.githubusercontent.com/raw/lcatlett/oauth2-server/pull/1.patch)
rachelwhitton marked this conversation as resolved.
Show resolved Hide resolved
* [Oauth Permission Patch - Required to resolve Pantheon known issues (PHP 7.4)](https://patch-diff.githubusercontent.com/raw/lcatlett/oauth2-server/pull/2.patch)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [Oauth Permission Patch - Required to resolve Pantheon known issues (PHP 7.4)](https://patch-diff.githubusercontent.com/raw/lcatlett/oauth2-server/pull/2.patch)
* [Oauth Permission Patch - Required to resolve Pantheon known issues (PHP 7.4)](https://patch-diff.githubusercontent.com/raw/pantheon-systems/oauth2-server/pull/2.patch)

Copy link
Member

@rachelwhitton rachelwhitton Jul 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevector I think you might have duplicated the first PR twice by mistake?

https://patch-diff.githubusercontent.com/raw/lcatlett/oauth2-server/pull/2.patch

vs

https://patch-diff.githubusercontent.com/raw/pantheon-systems/oauth2-server/pull/2.patch

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not exactly, I think @lcatlett's diff is bigger because it involves a merge commit too?

We probably need @lcatlett's expertise to explain why these patches are necessary. I don't understand why PHP different PHP versions need different patches.

Copy link
Member

@rachelwhitton rachelwhitton Jul 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah gotcha, my mistake I'll go ahead and commit this suggestion but mark the convo unresolved and reassign to you for next steps (defer to you on whether we merge or proceed with additional tech review first)


**Solution**: You can try to patch the [permission check in the module](https://github.com/thephpleague/oauth2-server/blob/e184691ded987c00966e341ac09c46ceeae0b27f/src/CryptKey.php#L51). The alternative is to use off-site key management tools like [Lockr](https://www.drupal.org/project/lockr)
___

## [Update Manager](https://www.drupal.org/docs/8/core/modules/update-manager) - Drupal 9 (core)
Expand Down
Loading