Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send config to cloud 1256 #1259

Merged
merged 3 commits into from
May 7, 2024
Merged

Send config to cloud 1256 #1259

merged 3 commits into from
May 7, 2024

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented May 7, 2024

  • Send config to db (and therefore firestore) the first time the db is set up.
  • Better parsing of floats and ints from cli.
  • Fix to pocs run auto for ensure simulators is always a list.

Closes #1256

wtgee added 2 commits May 6, 2024 19:06
@wtgee wtgee added the config Items related to configuration or the config file. label May 7, 2024
@wtgee wtgee self-assigned this May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 13.33333% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 71.71%. Comparing base (3d22a88) to head (7fa7353).
Report is 1 commits behind head on develop.

❗ Current head 7fa7353 differs from pull request most recent head f78aeea. Consider uploading reports for the commit f78aeea to get more accurate results

Files Patch % Lines
src/panoptes/pocs/utils/cli/config.py 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1259      +/-   ##
===========================================
+ Coverage    71.68%   71.71%   +0.02%     
===========================================
  Files          100      100              
  Lines         8401     8657     +256     
  Branches      1165     1247      +82     
===========================================
+ Hits          6022     6208     +186     
- Misses        2229     2298      +69     
- Partials       150      151       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtgee wtgee merged commit 0d756ff into develop May 7, 2024
5 checks passed
@wtgee wtgee deleted the send-config-to-cloud-1256 branch May 7, 2024 05:39
@wtgee wtgee mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Items related to configuration or the config file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send config info to cloud
1 participant