Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weather station autodetect #1254

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented May 2, 2024

When the weather sensor was introduced it used the term port instead of the serial_port that was found in the config. This led to some inconsistencies and bugs, so this PR cleans those up.

Tested on PAN026

@wtgee wtgee self-assigned this May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 70.21%. Comparing base (6bdacc8) to head (3c04b16).

❗ Current head 3c04b16 differs from pull request most recent head 2ee1ffa. Consider uploading reports for the commit 2ee1ffa to get more accurate results

Files Patch % Lines
src/panoptes/pocs/sensor/weather.py 0.00% 3 Missing ⚠️
src/panoptes/pocs/utils/service/weather.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1254      +/-   ##
===========================================
- Coverage    70.22%   70.21%   -0.02%     
===========================================
  Files          100      100              
  Lines         8399     8399              
  Branches      1164     1164              
===========================================
- Hits          5898     5897       -1     
  Misses        2352     2352              
- Partials       149      150       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wtgee wtgee merged commit 4092f40 into develop May 2, 2024
5 checks passed
@wtgee wtgee deleted the fix-weather-station-autodetect branch May 2, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant