Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Mahalanobis distance thresholding #31

Merged
merged 12 commits into from
Jan 27, 2025

Conversation

keeminlee
Copy link
Collaborator

No description provided.

eks/core.py Outdated
}


def inflate_variance(v, maha_results, threshold=5.0, scalar=2.0):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to multicam_smoother.py - it's only used there right?

@@ -53,7 +56,7 @@ def fit_eks_mirrored_multicam(
bodypart_list (list): List of body parts used.
"""
# Load and format input files
input_dfs_list, keypoint_names = format_data(input_source)
input_dfs_list, _, keypoint_names = format_data(input_source)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@@ -35,7 +37,8 @@
s_frames=s_frames,
camera_names=camera_names,
quantile_keep_pca=quantile_keep_pca,
verbose=verbose
verbose=verbose,
maha=maha
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change arg name

@@ -25,6 +25,7 @@
camera_names = args.camera_names
quantile_keep_pca = args.quantile_keep_pca
verbose = True if args.verbose == 'True' else False
maha = True if args.maha == 'True' else False
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change arg name

Copy link
Collaborator

@themattinthehatt themattinthehatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add unit test for inflate_variance

@themattinthehatt themattinthehatt merged commit 52007dd into main Jan 27, 2025
1 check passed
@themattinthehatt themattinthehatt deleted the keypoint-vectorized-multicam-funcs branch January 27, 2025 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants