-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Mahalanobis distance thresholding #31
Conversation
…om/paninski-lab/eks into keypoint-vectorized-multicam-funcs
eks/core.py
Outdated
} | ||
|
||
|
||
def inflate_variance(v, maha_results, threshold=5.0, scalar=2.0): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move to multicam_smoother.py
- it's only used there right?
eks/multicam_smoother.py
Outdated
@@ -53,7 +56,7 @@ def fit_eks_mirrored_multicam( | |||
bodypart_list (list): List of body parts used. | |||
""" | |||
# Load and format input files | |||
input_dfs_list, keypoint_names = format_data(input_source) | |||
input_dfs_list, _, keypoint_names = format_data(input_source) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
scripts/mirrored_multicam_example.py
Outdated
@@ -35,7 +37,8 @@ | |||
s_frames=s_frames, | |||
camera_names=camera_names, | |||
quantile_keep_pca=quantile_keep_pca, | |||
verbose=verbose | |||
verbose=verbose, | |||
maha=maha |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change arg name
scripts/multicam_example.py
Outdated
@@ -25,6 +25,7 @@ | |||
camera_names = args.camera_names | |||
quantile_keep_pca = args.quantile_keep_pca | |||
verbose = True if args.verbose == 'True' else False | |||
maha = True if args.maha == 'True' else False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change arg name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add unit test for inflate_variance
No description provided.