Fixed output formats to match singlecam #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themattinthehatt
requested changes
Jan 16, 2025
| @@ -26,7 +26,8 @@ def fit_eks_mirrored_multicam( | |||
| camera_names: Optional[list] = None, | |||
| quantile_keep_pca: float = 95, | |||
| avg_mode: str = 'median', | |||
| zscore_threshold: float = 2, | |||
| var_mode: str = 'confidence_weighted_var', | |||
| verbose: bool = False | |||
There was a problem hiding this comment.
add docstrings for these new args, remove docstring for zscore_threshold
| @@ -96,7 +105,8 @@ def fit_eks_multicam( | |||
| camera_names: Optional[list] = None, | |||
| quantile_keep_pca: float = 95, | |||
| avg_mode: str = 'median', | |||
| zscore_threshold: float = 2, | |||
| var_mode: str = 'confidence_weighted_var', | |||
| verbose: bool = False | |||
There was a problem hiding this comment.
add/remove corresponding entries in docstring
eks/multicam_smoother.py
Outdated
| input_dfs (list): List of input DataFrames for plotting. | ||
| bodypart_list (list): List of body parts used. | ||
|
|
||
| """ |
| @@ -89,7 +92,7 @@ def ensemble_kalman_smoother_singlecam( | |||
| blocks: list = [], | |||
| avg_mode: str = 'median', | |||
| var_mode: str = 'confidence_weighted_var', | |||
| zscore_threshold: float = 2, | |||
There was a problem hiding this comment.
remove from docstring
scripts/multicam_example.py
Outdated
| output_df=output_dfs[camera_c], | ||
| input_dfs_list=input_dfs[camera_c], | ||
| output_df=camera_dfs[1], | ||
| input_dfs_list=input_dfs[-1], |
There was a problem hiding this comment.
change these back to camera_c? indices should match
themattinthehatt
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.