Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mirrored and Un-mirrored multicam API improvements #24

Merged
merged 36 commits into from
Jan 8, 2025
Merged

Mirrored and Un-mirrored multicam API improvements #24

merged 36 commits into from
Jan 8, 2025

Conversation

keeminlee
Copy link
Collaborator

No description provided.

keeminlee and others added 30 commits July 15, 2024 14:38
@keeminlee
added verbose flag to reduce print statements
60da0e0
@keeminlee
merging
55b52c7
@keeminlee
merged
44036fb
@keeminlee
gerge branch 'main' of https://github.com/paninski-lab/eks into slp-c…
7b2e32c 
…onverter
@keeminlee
more verbose print removal
40ab165
@keeminlee
Merge branch 'slp-converter' of https://github.com/paninski-lab/eks i…
fa6808b 
…nto slp-converter
@keeminlee
more, more verbose print removal
ac25be8
@keeminlee
Merge branch 'slp-converter' of https://github.com/paninski-lab/eks i…
576622d 
…nto slp-converter
@keeminlee
outputs nll values
d3e80c9
@keeminlee
zscore threshold set
cf99cac
@keeminlee
eks scalar covariance inflation, initial pytest setup
8af094b
@keeminlee
removed SLEAP fish workaround
aa94ac3
@keeminlee
merge
6900f65
@keeminlee
Merge branch 'slp-converter' of https://github.com/paninski-lab/eks i…
c7e23ff 
…nto slp-converter
@keeminlee
added posterior var to eks output csvs
167a655
@keeminlee
merge
64cf946
@keeminlee
ens var dynamic update fix
754206f
@keeminlee
Merge branch 'slp-converter' of https://github.com/paninski-lab/eks i…
df500e9 
…nto slp-converter
@keeminlee
merge
747e58f
@keeminlee
Merge branch 'slp-converter' of https://github.com/paninski-lab/eks i…
2dc4789 
…nto slp-converter
@keeminlee
removed debug prints
64d1ad0
@keeminlee
fixed zscore indexing
62e53b7
@keeminlee
merged
4669928
@keeminlee
removed debug print for covariance scaling
3149b13
@keeminlee
flake8
6ada39b
@keeminlee
pytests for core functions WIP
aa25a02
@keeminlee
pytests and refactoring for cleaner file i/o
24edd5e
@keeminlee
Delete scripts/plotting_aeks.py
e0f0534
@keeminlee
Delete tests/run_tests.py
4619ab7
@keeminlee
Merged from main
00aff94
themattinthehatt
themattinthehatt requested changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@themattinthehatt themattinthehatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request to write a few more tests:

  1. in tests/scripts/test_mirrored_multicam_example.py can you add another test such that one is using a fixed smoothing param, and another is optimizing? (see tests/scripts/test_singlecam_example.py)
  2. make a new file tests/scripts/test_multicam_example.py that also runs two tests, one with fixed smoothing param and one that is optimized

eks/multicam_smoother.py Outdated Show resolved Hide resolved
themattinthehatt
themattinthehatt requested changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@themattinthehatt themattinthehatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good to me, but the tests failed so need to look into that

@themattinthehatt themattinthehatt merged commit c2381d7 into main Jan 8, 2025
1 check passed
@themattinthehatt themattinthehatt deleted the keeminlee branch January 8, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themattinthehatt themattinthehatt themattinthehatt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keeminlee @themattinthehatt