Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to meta.yaml #34

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Add version to meta.yaml #34

merged 2 commits into from
Oct 4, 2021

Conversation

rabernat
Copy link
Contributor

@rabernat rabernat commented Sep 16, 2021

This is an update to the meta.yaml spec which makes a proposal about how to handle versioning of datasets.

Closes pangeo-forge/pangeo-forge-recipes#3
xref pangeo-forge/pangeo-forge-recipes#37, #29

please review and comment @pangeo-forge/dev-team, @davidbrochart.

@rabernat
Copy link
Contributor Author

Please any comments on this?

Updates to the minor version number are considered minor changes;
when a new minor version is released, bakeries will _overwrite the previous minor version_ of the feedstock's datasets.
Instead, the bakery should _always retain the latest major version_.
Updates that involve concatenation of new elements (e.g. extend the temporal range) are considered minor version updates.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wording is confusing - didn't you just say that this would overwrite the dataset?

Similarly, retaining the major version: you mean that the latest minor version of each major version will be retained? i.e., that if 3.7 was followed by a 4.x series, then 3.7 will be kept for good, archival?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't you just say that this would overwrite the dataset?

Yes I see how that is confusing. What I mean is that 3.6 ➡️ 3.7 will make 3.6 go away. We won't keep a separate copy of 3.6 around, since 3.7 supersedes it. But this may mean just renaming 3.6 to 3.7 and then appending to it. So I agree that "overwrite" is not necessarily the right word here.

if 3.7 was followed by a 4.x series, then 3.7 will be kept for good, archival?

Correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Versioning and encoding
3 participants