Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference Recipe Add Target Options #399

Merged
merged 4 commits into from
Aug 30, 2022

Conversation

peterm790
Copy link

This is following from pangeo-forge/staged-recipes#154 (comment)

I think this should be sufficient to get the LiveOcean recipe to run. I have not set up any tests for this as I'm not entirely sure how that could be done.

Copy link
Contributor

@rabernat rabernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this contribution!

It's probably simplest to use the same exact keyword name.

Also, we would need an entry for this in the docstring.

pangeo_forge_recipes/recipes/reference_hdf_zarr.py Outdated Show resolved Hide resolved
pangeo_forge_recipes/recipes/reference_hdf_zarr.py Outdated Show resolved Hide resolved
peterm790 and others added 2 commits August 23, 2022 12:00
change keyword names to `target_options`

Co-authored-by: Ryan Abernathey <[email protected]>
@peterm790
Copy link
Author

Thank you @rabernat
I have committed the recommended changes and updated the docstring!

@rsignell-usgs
Copy link

@rabernat or @cisaacstern what say ye?

@rabernat rabernat merged commit ae41891 into pangeo-forge:master Aug 30, 2022
@cisaacstern
Copy link
Member

Thanks @peterm790 and @rsignell-usgs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants