Add chunk grid logic #141
Merged
Add chunk grid logic #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Ryan! I noticed that this approach seems a lot like XArray-Beams's I'd love to talk more about the approach you're taking here, and how we can generalize this pattern. |
rabernat
force-pushed
the
add-chunk-grid
branch
from
d84b0b8
to
36a10ee
Compare
rabernat
commented
Aug 21, 2021
| dim_idx.index | ||
| for dim_idx in chunk_key | ||
| if dim_idx.operation == CombineOp.SUBSET and dim_idx.name == concat_dim | ||
| ][0] |
There was a problem hiding this comment.
Note how we no longer need this opaque logic in this function. It now lives in ChunkGrid.
There was a problem hiding this comment.
(and the new chunk_position function, which translates a ChunkKey to a chunk index)
| for conflict_index in conflict: | ||
| this_chunk_conflicts.add(conflict_index) | ||
|
|
||
| return {concat_dim: region_slice}, this_chunk_conflicts |
There was a problem hiding this comment.
Same. All this code goes away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first start on closing #140 and #98.
Let's create a new abstract class called ChunkGrid that understands about the mapping between chunk indexes and array slices and implement methods to find the overlap / intersection between different grids. Then we can refactor XarrayZarrRecipe to use this rather than its current impenetrable logic.
This is definitely WIP; just wanted to push something to get the conversation started.