Switch to buildx for github actions #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
scottyhq
commented
Oct 17, 2022
scottyhq
commented
- Switch to docker github actions such as (docker/build-push-action) that are more flexible for newer buildkit options (Docker BuildX for parallel builds and conda package cache #357)
- Use only docker, not docker and podman for quay.io to speed up CI (fixes New DockerHub Image retention policies will delete unused images after 6 months #121 (comment)
- Cancel concurrent Binder and Test workflows for PRs if multiple commits are made
* use docker buildx in Test workflow
|
|
weiji14
reviewed
Oct 17, 2022
Comment on lines
+57
to
+59
| ${{env.DOCKER_ORG}}/${{ env.IMAGE }}:master | ||
| ${{env.DOCKER_ORG}}/${{ env.IMAGE }}:${{env.DOCKER_TAG}} | ||
| quay.io/${{env.DOCKER_ORG}}/${{ env.IMAGE }}:master |
There was a problem hiding this comment.
Just flagging the use of master as the docker image tag... I suppose this is just following the git repo's master branch right now, and latest needs to be explicitly tagged (i.e. latest is semi-stable)?
There was a problem hiding this comment.
exactly. explained here https://github.com/pangeo-data/pangeo-docker-images#image-tagging-and-continuous-building
|
Nice work @scottyhq! This seems like a huge improvement. Thanks for your maintenance work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.