feat: write/read .og files during intermediate smoothing iterations #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even for "mid-sized" graphs (n~25 haplotypes and 100 Mb), the
odgi::gfa_to_handlestep could take up something like ~10% of the entire smoothxg walltime. Presumably this would scale poorly with more haplotypes as path information starts to dominate. Serialising the graph is already implemented and most people probably don't keep intermediate files, so this likely has no external change. Worst case a user can runodgi view -g -i <graph.og>to get the gfa version of the intermediate graphs.Debatably the output could also beThis was easy enough to just toggle based on the extension of the output file..og, since the next step in pggb is to sort the graph with odgi, but that is out of scope for here.