BUG: Fix Series.str.zfill for ArrowDtype string arrays #61485 #61533
+31
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jun 2, 2025
| @@ -2601,6 +2601,12 @@ def _str_wrap(self, width: int, **kwargs) -> Self: | |||
| result = self._apply_elementwise(predicate) | |||
| return type(self)(pa.chunked_array(result)) | |||
|
|
|||
| def _str_zfill(self, width: int) -> Self: | |||
| # TODO: Replace with pc.utf8_zfill when supported by arrow | |||
There was a problem hiding this comment.
Is there an actual Github issue on the arrow project about utf8_zfill?
There was a problem hiding this comment.
Just created one - apache/arrow#46683
There was a problem hiding this comment.
Can you use this solution apache/arrow#46683 (comment)?
There was a problem hiding this comment.
Can you use this solution apache/arrow#46683 (comment)?
@mroeschke That solution is not clean as it misses an important edge case ('-1', '+1'), I will be working on implementing that dedicated pc.utf8_zfill(array, width) and it will be available to us upstream.
Meanwhile, do you suggest we keep the current implementation with a TODO or should I change this to use pc.utf8_lpad with some custom logic for sign handling?
mroeschke
requested changes
Jun 2, 2025
iabhi4
force-pushed
the
bugfix-arrow-str-zfill
branch
2 times, most recently
from
bab4b9a to
1d5c66f
Compare
mroeschke
reviewed
Jun 4, 2025
iabhi4
force-pushed
the
bugfix-arrow-str-zfill
branch
from
82ed761 to
057db65
Compare
iabhi4
force-pushed
the
bugfix-arrow-str-zfill
branch
from
057db65 to
5bd175a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
_str_zfillforArrowExtensionArrayto supportSeries.str.zfillon Arrow-backed string arrays (ArrowDtype(pa.string())). This fixes an AttributeError due to the method relying on_str_map, which wasn't implemented. Used_apply_elementwiseto match the approach of other string methods. Added tests undertest_string_array.pyand confirmed they pass. Also confirmed no other relevant test files are broken and the change aligns with how other string accessors are handled.