Skip to content

ENH: Support skipna parameter in GroupBy min, max, prod, median, var, std and sem methods #60752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Feb 3, 2025
Merged

ENH: Support skipna parameter in GroupBy min, max, prod, median, var, std and sem methods #60752

merged 12 commits into from
Feb 3, 2025

Conversation

snitish
Copy link
Member

@snitish snitish commented Jan 22, 2025 •
edited
Loading

Second (and final) batch of GroupBy reductions being enhanced to support the skipna parameter.

@snitish snitish marked this pull request as draft January 22, 2025 01:33
WillAyd
WillAyd requested changes Jan 22, 2025
View reviewed changes
@snitish snitish changed the title ENH: Support skipna parameter in GroupBy prod, var, std and sem methods ENH: Support skipna parameter in GroupBy min, max, prod, var, std and sem methods Jan 22, 2025
@snitish snitish marked this pull request as ready for review January 22, 2025 04:14
@snitish snitish changed the title ENH: Support skipna parameter in GroupBy min, max, prod, var, std and sem methods ENH: Support skipna parameter in GroupBy min, max, prod, median, var, std and sem methods Jan 22, 2025
WillAyd
WillAyd reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. One question

WillAyd
WillAyd requested changes Jan 22, 2025
View reviewed changes
WillAyd
WillAyd reviewed Jan 22, 2025
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few smaller comments. @rhshadrach mind taking a look as well?

@rhshadrach rhshadrach added Enhancement Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate labels Jan 25, 2025
@rhshadrach rhshadrach added this to the 3.0 milestone Jan 25, 2025
rhshadrach
rhshadrach requested changes Jan 25, 2025
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Can you add a test (adding to your current parametrizations would be fine) where the entire group is NA.

@snitish
Copy link
Member Author

snitish commented Jan 25, 2025

Looks great! Can you add a test (adding to your current parametrizations would be fine) where the entire group is NA.

Thanks for the review @rhshadrach. Added the all-NA tests and responded to comments.

@rhshadrach
Copy link
Member

Failure on the future infer string is unrelated (and is fixed by #60796). Rerunning Ubuntu 310 just to be sure.

@snitish snitish requested a review from rhshadrach January 31, 2025 02:47
rhshadrach
rhshadrach approved these changes Feb 2, 2025
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach
Copy link
Member

@WillAyd - you good here?

@WillAyd WillAyd merged commit a68048e into pandas-dev:main Feb 3, 2025
41 of 42 checks passed
@WillAyd
Copy link
Member

WillAyd commented Feb 3, 2025

Thanks @snitish

@snitish snitish mentioned this pull request Feb 3, 2025
Merged
ShashwatAgrawal20 pushed a commit to ShashwatAgrawal20/pandas that referenced this pull request Feb 4, 2025
@snitish @ShashwatAgrawal20
ENH: Support skipna parameter in GroupBy min, max, prod, median, var,…
92542e4 
… std and sem methods (pandas-dev#60752)
@snitish snitish deleted the issue15675 branch February 6, 2025 19:46
@rhshadrach rhshadrach mentioned this pull request Feb 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillAyd WillAyd WillAyd approved these changes

@rhshadrach rhshadrach rhshadrach approved these changes

Assignees
No one assigned
Labels
Enhancement Groupby Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

ENH: enable skipna on groupby reduction ops
3 participants
@snitish @rhshadrach @WillAyd