-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax meson pins in CI #60681
Open
WillAyd
wants to merge
11
commits into
pandas-dev:main
Choose a base branch
from
WillAyd:remove-meson-pins
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Relax meson pins in CI #60681
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
84f7de4
Relax meson pins in CI
WillAyd 356529b
Ignore Cython generated unused-function errors
WillAyd 6e56802
Fix uninitialized warning
WillAyd 05c4c12
Help gcc-11.4
WillAyd 3e200a6
Ignore narrowing conversion warning on MSVC
WillAyd 76beb1e
Remove linker flags from windows
WillAyd 7083aaf
More MSVC fix
WillAyd 2c0911d
More MSVC
WillAyd 8d6d29c
Upper bound for meson-python
WillAyd a439bce
Revert "Upper bound for meson-python"
WillAyd 4136fa9
Use different jinja loader to work with meson-python
WillAyd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ | |
# See https://github.com/scipy/scipy/pull/12940 for the AIX issue. | ||
requires = [ | ||
"meson-python>=0.13.1", | ||
"meson>=1.2.1,<2", | ||
"meson>=1.2.1", | ||
"wheel", | ||
"Cython~=3.0.5", # Note: sync with setup.py, environment.yml and asv.conf.json | ||
# Force numpy higher than 2.0rc1, so that built wheels are compatible | ||
|
@@ -149,7 +149,6 @@ setup = ['--vsenv'] # For Windows | |
[tool.cibuildwheel] | ||
skip = "cp36-* cp37-* cp38-* cp39-* pp* *_i686 *_ppc64le *_s390x" | ||
build-verbosity = "3" | ||
environment = {LDFLAGS="-Wl,--strip-all"} | ||
test-requires = "hypothesis>=6.84.0 pytest>=7.3.2 pytest-xdist>=3.4.0" | ||
test-command = """ | ||
PANDAS_CI='1' python -c 'import pandas as pd; \ | ||
|
@@ -159,6 +158,12 @@ test-command = """ | |
free-threaded-support = true | ||
before-build = "PACKAGE_DIR={package} bash {package}/scripts/cibw_before_build.sh" | ||
|
||
[tool.cibuildwheel.macos] | ||
environment = {LDFLAGS="-Wl,--strip-all"} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These flags are not applicable on windows and were causing the linker to throw an error when combined with -Werror in our CI |
||
|
||
[tool.cibuildwheel.linux] | ||
environment = {LDFLAGS="-Wl,--strip-all"} | ||
|
||
[tool.cibuildwheel.windows] | ||
before-build = "pip install delvewheel && bash {package}/scripts/cibw_before_build_windows.sh" | ||
before-test = "bash {package}/scripts/cibw_before_test_windows.sh" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the <2 as I didn't want to repeat it everywhere in our CI configurations, and we don't create upper bounds like this on any other dependency. There also is not a meson 2.0 under development