TST (string dtype): resolve xfails in pandas/tests/copy_view #60245
Conversation
| if using_infer_string: | ||
| # TODO the default nullable string dtype still uses python storage | ||
| # this should be changed to pyarrow if installed | ||
| assert not tm.shares_memory(get_array(df2, "a"), get_array(df, "a")) |
There was a problem hiding this comment.
Because the df starts with using str dtype with pyarrow storage (if pyarrow is installed, so just realize this needs a HAS_PYARROW check), and convert_dtypes will convert this to the nullable string dtype but using python storage (because that is still the default storage in this case, but we should change that before 3.0)
There was a problem hiding this comment.
Ah OK - so this is really just a 2.3 behavior nuance?
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
…dev#60245) (cherry picked from commit 084b199)
|
Manual backport -> #60257 |
One remaining xfail is due to Index not preserving dtype through
join, which sounds like an actual bug.xref #54792