Fix part of docstring timedelta #59698 #59722
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/_libs/tslibs/timedeltas.pyx
Outdated
| @@ -1835,6 +1835,21 @@ class Timedelta(_Timedelta): | |||
| Values for construction in compat with datetime.timedelta. | |||
| Numpy ints and floats will be coerced to python ints and floats. | |||
|
|
|||
| **Attributes | |||
There was a problem hiding this comment.
this is probably fine, but you need to remove the leading **
There was a problem hiding this comment.
Thanks for the review. I've removed the leading **.
ammar-qazi
force-pushed
the
doc_update
branch
from
d98453e
to
c09257b
Compare
ammar-qazi
force-pushed
the
doc_update
branch
from
c09257b
to
fa1f22f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of 59698
Addresses:
pandas.Timedelta
Added the missing explanations (PRO2) for min, max, and resolution.
Removed:
from code_checks.sh
p.s. I'm not 100% confident if this is the appropriate way to document these attributes. That said, they're being defined by a class called
MinMaxReso, and they don't have their separate definitions per se. So, I found this most appropriate way to document them.