TST (string dtype): xfail all currently failing tests with future.infer_string #59329

jorisvandenbossche · 2024-07-26T14:38:34Z

~~On top of #59320 and #59323~~ (both merged now)

#58459 added a CI build with future.infer_string enabled, but did not yet surface any failures in a red status (still many tests failing).

I was thinking to add xfails to all currently failing tests, then we can actually enable the CI build properly (now the failure is just suppressed), which might be easier for follow-up PRs to actually tackle those failures part by part.

I mostly blindly added @pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string)") to any test that is currently still failing on the build that enables the future string dtype, i.e. without looking into why it is failing or whether it is an easy fix or not. That can be done in chunks after this PR (essentially after this, we have to go through any of those xfails and fix the code or fix the test to get it passing properly).

xref #54792

…er_string

mroeschke

Looks like you'll need to uncommit pandas/tests/io/data/excel/test_boolean_types.xlsx

pandas/tests/apply/test_frame_apply.py

.github/workflows/unit-tests.yml

…all-xfail

jorisvandenbossche · 2024-07-29T18:06:23Z

@mroeschke thanks for the review! (and removed the xlsx file)

mroeschke · 2024-07-29T21:17:29Z

Thanks @jorisvandenbossche

jorisvandenbossche · 2024-07-30T12:10:33Z

This seems to have caused a few failures on main that for some reason didn't show up in this PR ..
Not directly sure how to explain that, but looking into them.

jorisvandenbossche · 2024-07-30T12:11:31Z

Ah, I suppose it was because of the merging of #59330 before merging this PR (and we should have re-run this PR again after that was merged)

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

…er_string (pandas-dev#59329) * TST (string dtype): xfail all currently failing tests with future.infer_string * more xfails * more xfails * add missing strict=False * also run slow and single cpu tests * fix single_cpu tests * xfail some slow tests * stop suppressing non-zero exit code from pytest on string CI build * remove accidentally added xlsx file --------- Co-authored-by: Matthew Roeschke <[email protected]>

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

…er_string (pandas-dev#59329) * TST (string dtype): xfail all currently failing tests with future.infer_string * more xfails * more xfails * add missing strict=False * also run slow and single cpu tests * fix single_cpu tests * xfail some slow tests * stop suppressing non-zero exit code from pytest on string CI build * remove accidentally added xlsx file --------- Co-authored-by: Matthew Roeschke <[email protected]>

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

…er_string (pandas-dev#59329) * TST (string dtype): xfail all currently failing tests with future.infer_string * more xfails * more xfails * add missing strict=False * also run slow and single cpu tests * fix single_cpu tests * xfail some slow tests * stop suppressing non-zero exit code from pytest on string CI build * remove accidentally added xlsx file --------- Co-authored-by: Matthew Roeschke <[email protected]>

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

…er_string (pandas-dev#59329) * TST (string dtype): xfail all currently failing tests with future.infer_string * more xfails * more xfails * add missing strict=False * also run slow and single cpu tests * fix single_cpu tests * xfail some slow tests * stop suppressing non-zero exit code from pytest on string CI build * remove accidentally added xlsx file --------- Co-authored-by: Matthew Roeschke <[email protected]>

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

…er_string (pandas-dev#59329) * TST (string dtype): xfail all currently failing tests with future.infer_string * more xfails * more xfails * add missing strict=False * also run slow and single cpu tests * fix single_cpu tests * xfail some slow tests * stop suppressing non-zero exit code from pytest on string CI build * remove accidentally added xlsx file --------- Co-authored-by: Matthew Roeschke <[email protected]>

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

…er_string (pandas-dev#59329) * TST (string dtype): xfail all currently failing tests with future.infer_string * more xfails * more xfails * add missing strict=False * also run slow and single cpu tests * fix single_cpu tests * xfail some slow tests * stop suppressing non-zero exit code from pytest on string CI build * remove accidentally added xlsx file --------- Co-authored-by: Matthew Roeschke <[email protected]>

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

…er_string (pandas-dev#59329) * TST (string dtype): xfail all currently failing tests with future.infer_string * more xfails * more xfails * add missing strict=False * also run slow and single cpu tests * fix single_cpu tests * xfail some slow tests * stop suppressing non-zero exit code from pytest on string CI build * remove accidentally added xlsx file --------- Co-authored-by: Matthew Roeschke <[email protected]>

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

…er_string (pandas-dev#59329) * TST (string dtype): xfail all currently failing tests with future.infer_string * more xfails * more xfails * add missing strict=False * also run slow and single cpu tests * fix single_cpu tests * xfail some slow tests * stop suppressing non-zero exit code from pytest on string CI build * remove accidentally added xlsx file --------- Co-authored-by: Matthew Roeschke <[email protected]>

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

…er_string (pandas-dev#59329) * TST (string dtype): xfail all currently failing tests with future.infer_string * more xfails * more xfails * add missing strict=False * also run slow and single cpu tests * fix single_cpu tests * xfail some slow tests * stop suppressing non-zero exit code from pytest on string CI build * remove accidentally added xlsx file --------- Co-authored-by: Matthew Roeschke <[email protected]>

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

…er_string (pandas-dev#59329) * TST (string dtype): xfail all currently failing tests with future.infer_string * more xfails * more xfails * add missing strict=False * also run slow and single cpu tests * fix single_cpu tests * xfail some slow tests * stop suppressing non-zero exit code from pytest on string CI build * remove accidentally added xlsx file --------- Co-authored-by: Matthew Roeschke <[email protected]>

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

…er_string (pandas-dev#59329) * TST (string dtype): xfail all currently failing tests with future.infer_string * more xfails * more xfails * add missing strict=False * also run slow and single cpu tests * fix single_cpu tests * xfail some slow tests * stop suppressing non-zero exit code from pytest on string CI build * remove accidentally added xlsx file --------- Co-authored-by: Matthew Roeschke <[email protected]>

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

…er_string (pandas-dev#59329) * TST (string dtype): xfail all currently failing tests with future.infer_string * more xfails * more xfails * add missing strict=False * also run slow and single cpu tests * fix single_cpu tests * xfail some slow tests * stop suppressing non-zero exit code from pytest on string CI build * remove accidentally added xlsx file --------- Co-authored-by: Matthew Roeschke <[email protected]>

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

…er_string (#59329) * TST (string dtype): xfail all currently failing tests with future.infer_string * more xfails * more xfails * add missing strict=False * also run slow and single cpu tests * fix single_cpu tests * xfail some slow tests * stop suppressing non-zero exit code from pytest on string CI build * remove accidentally added xlsx file --------- Co-authored-by: Matthew Roeschke <[email protected]>

* TST (string dtype): follow-up on GH-59329 fixing new xfails * add missing strict

jorisvandenbossche mentioned this pull request Jul 26, 2024

TRACKER: new default String dtype (pyarrow-backed, numpy NaN semantics) #54792

Open

41 tasks

jorisvandenbossche force-pushed the string-dtype-tests-all-xfail branch from d2f3903 to 2a7a7d4 Compare July 26, 2024 19:41

jorisvandenbossche added 6 commits July 27, 2024 17:14

TST (string dtype): xfail all currently failing tests with future.inf…

b7b7c6d

…er_string

more xfails

dc7ae02

more xfails

8610cbd

add missing strict=False

8f5a6b3

also run slow and single cpu tests

1563ff9

fix single_cpu tests

653f73a

jorisvandenbossche force-pushed the string-dtype-tests-all-xfail branch from 5976535 to 653f73a Compare July 27, 2024 15:39

jorisvandenbossche added 2 commits July 27, 2024 19:29

xfail some slow tests

03cd904

stop suppressing non-zero exit code from pytest on string CI build

2477304

jorisvandenbossche marked this pull request as ready for review July 27, 2024 17:30

jorisvandenbossche requested a review from mroeschke as a code owner July 27, 2024 17:30

tirthrajj mentioned this pull request Jul 28, 2024

TST: Add test for numpy.maximum with Timestamp and Series of datetime64 #59338

Merged

3 tasks

jorisvandenbossche added Testing pandas testing functions or related to the test suite Strings String extension data type and string data labels Jul 29, 2024

mroeschke reviewed Jul 29, 2024

View reviewed changes

pandas/tests/apply/test_frame_apply.py Show resolved Hide resolved

mroeschke reviewed Jul 29, 2024

View reviewed changes

.github/workflows/unit-tests.yml Show resolved Hide resolved

jorisvandenbossche added 2 commits July 29, 2024 20:05

remove accidentally added xlsx file

d75722c

Merge remote-tracking branch 'upstream/main' into string-dtype-tests-…

1f7d552

…all-xfail

Merge branch 'main' into string-dtype-tests-all-xfail

012875a

mroeschke added this to the 3.0 milestone Jul 29, 2024

mroeschke approved these changes Jul 29, 2024

View reviewed changes

mroeschke merged commit 9c8c685 into pandas-dev:main Jul 29, 2024
39 of 45 checks passed

jorisvandenbossche deleted the string-dtype-tests-all-xfail branch July 30, 2024 06:37

WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 14, 2024

TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails (…

ce369f9

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 15, 2024

TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails (…

43af8ab

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 15, 2024

TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails (…

e71d572

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 15, 2024

TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails (…

c318fe7

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

jorisvandenbossche modified the milestones: 3.0, 2.3 Aug 20, 2024

WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 21, 2024

TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails (…

26a5f0f

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 22, 2024

TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails (…

fa47e94

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 22, 2024

TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails (…

b7e0fc8

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 27, 2024

TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails (…

474241a

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Sep 20, 2024

TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails (…

478ce59

…pandas-dev#59352) * TST (string dtype): follow-up on pandas-devGH-59329 fixing new xfails * add missing strict

jorisvandenbossche added a commit that referenced this pull request Oct 9, 2024

TST (string dtype): follow-up on GH-59329 fixing new xfails (#59352)

d36a5aa

* TST (string dtype): follow-up on GH-59329 fixing new xfails * add missing strict

jorisvandenbossche added the backported label Oct 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TST (string dtype): xfail all currently failing tests with future.infer_string #59329

TST (string dtype): xfail all currently failing tests with future.infer_string #59329

jorisvandenbossche commented Jul 26, 2024 •

edited

Loading

mroeschke left a comment

jorisvandenbossche commented Jul 29, 2024

mroeschke commented Jul 29, 2024

jorisvandenbossche commented Jul 30, 2024

jorisvandenbossche commented Jul 30, 2024

TST (string dtype): xfail all currently failing tests with future.infer_string #59329

TST (string dtype): xfail all currently failing tests with future.infer_string #59329

Conversation

jorisvandenbossche commented Jul 26, 2024 • edited Loading

mroeschke left a comment

Choose a reason for hiding this comment

jorisvandenbossche commented Jul 29, 2024

mroeschke commented Jul 29, 2024

jorisvandenbossche commented Jul 30, 2024

jorisvandenbossche commented Jul 30, 2024

jorisvandenbossche commented Jul 26, 2024 •

edited

Loading