Infer large_string type as pyarrow_numpy strings #54826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Strings
phofl
changed the title
|
Looks good to me. We should handle the case of a too large array that would need to be split for being able to cast to "string", but that's fine for a follow up. Can you open an issue for that? |
|
I was planning on keeping the other issue open |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Sep 2, 2023
phofl
added a commit
that referenced
this pull request
Sep 2, 2023
…w_numpy strings) (#54969) Backport PR #54826: Infer large_string type as pyarrow_numpy strings Co-authored-by: Patrick Hoefler <[email protected]>
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.this covers the case where we don't overflow