type freq in shift #1108
Open
type freq in shift #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoGorelli
commented
Feb 8, 2025
| @@ -416,10 +416,11 @@ def test_types_sort_values_with_key() -> None: | |||
|
|
|||
|
|
|||
| def test_types_shift() -> None: | |||
| s = pd.Series([1, 2, 3]) | |||
| s = pd.Series([1, 2, 3], index=pd.date_range("2020", periods=3)) | |||
There was a problem hiding this comment.
🤔 trying to add a test for this, the type actually changes from Series['int'] to Series['float'], taking a look
This was referenced Feb 8, 2025
MarcoGorelli
commented
Feb 8, 2025
Comment on lines
+420
to
+422
| # Return type "Series[int]"" not quite correct | ||
| # - https://github.com/pandas-dev/pandas-stubs/issues/1111 | ||
| # - https://github.com/pandas-dev/pandas-stubs/issues/1110 |
There was a problem hiding this comment.
I've kept the return type of shift as-is, in order to focus on typing freq
Happy to update the return type too based on discussion in the issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assert_type()to assert the type of any return value