Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYP: Fix return type of Series.keys() fro list to Index (#1101) #1106

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

TYP: Fix return type of Series.keys() fro list to Index (#1101) #1106

wants to merge 5 commits into from

Conversation

janlodewijk
Copy link

No description provided.

@janlodewijk
Update series.pyi, tackling issue pandas-dev#1101
926450b 
Imported Index from pandas
and
Changed keys method:
def keys(self) -> Index: ...
Dr-Irv
Dr-Irv requested changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test for this?

@janlodewijk
Update test_series.py
ed85e9a 
Add a test for issue # 1101
Dr-Irv
Dr-Irv requested changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have our tests in a specific pattern, so I have suggested that pattern in my review.

tests/test_series.py Outdated Show resolved Hide resolved
@janlodewijk @Dr-Irv
Update tests/test_series.py
35bd06f 
Following the pandas pattern.

Co-authored-by: Irv Lustig <[email protected]>
@janlodewijk
Copy link
Author

Thank you for your feedback. It's my very first issue and pull request.

Dr-Irv
Dr-Irv requested changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to set up the pre-commit so things are properly formatted. See the output here:
https://github.com/pandas-dev/pandas-stubs/actions/runs/13202706637/job/36858930373?pr=1106

And instructions here for setting up your local testing environment:
https://github.com/pandas-dev/pandas-stubs/blob/main/docs/setup.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dr-Irv Dr-Irv Dr-Irv requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janlodewijk @Dr-Irv