Simplify and fix overloads for methods with inplace parameter
#1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return value of these methods varies on the `inplace` argument.
Dr-Irv
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Tests are failing. Please make sure to run the tests locally before resubmitting.
I understand what you are trying to do here, and it seems correct, but I also would like to know what prompted you to make these changes. Is there a test we can add that fails with the current stubs but passes with your changes?
Comment on lines
-514
to
-519
| level: Sequence[Level] = ..., | ||
| *, | ||
| drop: bool = ..., | ||
| name: Level = ..., | ||
| inplace: Literal[True], | ||
| allow_duplicates: bool = ..., |
There was a problem hiding this comment.
I don't think you can remove this overload.
| level: Level | None = ..., | ||
| errors: IgnoreRaise = ..., | ||
| ) -> Series | None: ... | ||
| ) -> Series[S1]: ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return value of these methods varies on the
inplaceargument.