Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove lmPool from Bin #20

Merged
merged 3 commits into from
Apr 17, 2024
Merged

chore: remove lmPool from Bin #20

merged 3 commits into from
Apr 17, 2024

Conversation

ChefMist
Copy link
Collaborator

This PR removes lmPool from bin

resolve #5

chefburger
chefburger previously approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@chefburger chefburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ChefSnoopy
Copy link
Collaborator

Need to format the codes.

@ChefSnoopy
Copy link
Collaborator

One suggestion, now we have removed the codes , maybe we can raise the optimizer_runs.
1600 should be good.

@ChefMist ChefMist mentioned this pull request Apr 17, 2024
Closed
@ChefMist ChefMist merged commit 25500aa into main Apr 17, 2024
2 checks passed
@ChefMist ChefMist deleted the chore/remove-lmpool branch April 17, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChefSnoopy ChefSnoopy ChefSnoopy approved these changes

@chefburger chefburger chefburger left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double check on LMPool
3 participants
@ChefMist @ChefSnoopy @chefburger