feat: [internal-r8] require lock for sync and require unlock for coll… #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChefSnoopy
approved these changes
Sep 9, 2024
|
Merged into audit-part-5, pls feel free to add comments if find anything @ChefMist |
chefburger
added a commit
that referenced
this pull request
Sep 9, 2024
* optimizaiton: [internal-s35] reuse calculation in computeSwapStep#exactIn case * feat: [internal-S36] add feesAccrued as an argument of afterModifyLiquidity * feat: [internal-S37] a set of small optimization * feat: [internal-S38] using PoolIdLibrary for PoolKey global; * feat: [internal-r7] fix priceLimit check * feat: [internal-r8] require lock for sync and require unlock for collectFee (#160) * feat: Update MIN_BIN_SHARE_FOR_DONATE check (#158) * [internal-s39] simplified safeCast (#163) --------- Co-authored-by: ChefMist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ectFee