tweak: use unchecked

pancakeswap · Apr 29, 2024 · e1710a0 · e1710a0
1 parent b0cd33f
commit e1710a0
Show file tree

Hide file tree

Showing 16 changed files with 27 additions and 21 deletions.
diff --git a/.forge-snapshots/BinPoolManagerTest#testBurnNativeCurrency.snap b/.forge-snapshots/BinPoolManagerTest#testBurnNativeCurrency.snap
@@ -1 +1 @@
-90479
+90473
diff --git a/.forge-snapshots/BinPoolManagerTest#testGasBurnHalfBin.snap b/.forge-snapshots/BinPoolManagerTest#testGasBurnHalfBin.snap
@@ -1 +1 @@
-65672
+65666
diff --git a/.forge-snapshots/BinPoolManagerTest#testGasBurnNineBins.snap b/.forge-snapshots/BinPoolManagerTest#testGasBurnNineBins.snap
@@ -1 +1 @@
-149227
+149221
diff --git a/.forge-snapshots/BinPoolManagerTest#testGasBurnOneBin.snap b/.forge-snapshots/BinPoolManagerTest#testGasBurnOneBin.snap
@@ -1 +1 @@
-66851
+66845
diff --git a/.forge-snapshots/BinPoolManagerTest#testGasSwapMultipleBins.snap b/.forge-snapshots/BinPoolManagerTest#testGasSwapMultipleBins.snap
@@ -1 +1 @@
-89312
+89309
diff --git a/.forge-snapshots/BinPoolManagerTest#testGasSwapOverBigBinIdGate.snap b/.forge-snapshots/BinPoolManagerTest#testGasSwapOverBigBinIdGate.snap
@@ -1 +1 @@
-91297
+91294
diff --git a/.forge-snapshots/BinPoolManagerTest#testGasSwapSingleBin.snap b/.forge-snapshots/BinPoolManagerTest#testGasSwapSingleBin.snap
@@ -1 +1 @@
-70741
+70738
diff --git a/.forge-snapshots/CLPoolManagerTest#removeLiquidity_toNonEmpty.snap b/.forge-snapshots/CLPoolManagerTest#removeLiquidity_toNonEmpty.snap
@@ -1 +1 @@
-41768
+41765
diff --git a/.forge-snapshots/CLPoolManagerTest#swap_againstLiquidity.snap b/.forge-snapshots/CLPoolManagerTest#swap_againstLiquidity.snap
@@ -1 +1 @@
-54672
+54669
diff --git a/.forge-snapshots/CLPoolManagerTest#swap_runOutOfLiquidity.snap b/.forge-snapshots/CLPoolManagerTest#swap_runOutOfLiquidity.snap
@@ -1 +1 @@
-25040256
+25040253
diff --git a/.forge-snapshots/CLPoolManagerTest#swap_useSurplusTokenAsInput.snap b/.forge-snapshots/CLPoolManagerTest#swap_useSurplusTokenAsInput.snap
@@ -1 +1 @@
-101510
+101507
diff --git a/.forge-snapshots/VaultTest#Vault.snap b/.forge-snapshots/VaultTest#Vault.snap
@@ -1 +1 @@
-7314
+7318
diff --git a/.forge-snapshots/VaultTest#lockSettledWhenFlashloan.snap b/.forge-snapshots/VaultTest#lockSettledWhenFlashloan.snap
@@ -1 +1 @@
-156938
+156932
diff --git a/.forge-snapshots/VaultTest#lockSettledWhenMultiHopSwap.snap b/.forge-snapshots/VaultTest#lockSettledWhenMultiHopSwap.snap
@@ -1 +1 @@
-45186
+45183
diff --git a/.forge-snapshots/VaultTest#lockSettledWhenSwap.snap b/.forge-snapshots/VaultTest#lockSettledWhenSwap.snap
@@ -1 +1 @@
-45185
+45182
diff --git a/src/Vault.sol b/src/Vault.sol
@@ -106,15 +106,19 @@ contract Vault is IVault, VaultToken, Ownable {
 
     /// @inheritdoc IVault
     function take(Currency currency, address to, uint256 amount) external override isLocked {
-        SettlementGuard.accountDelta(msg.sender, currency, amount.toInt128());
+        unchecked {
+            SettlementGuard.accountDelta(msg.sender, currency, amount.toInt128());
+            currency.transfer(to, amount);
+        }
         reservesOfVault[currency] -= amount;
-        currency.transfer(to, amount);
     }
 
     /// @inheritdoc IVault
     function mint(address to, Currency currency, uint256 amount) external override isLocked {
-        SettlementGuard.accountDelta(msg.sender, currency, amount.toInt128());
-        _mint(to, currency, amount);
+        unchecked {
+            SettlementGuard.accountDelta(msg.sender, currency, amount.toInt128());
+            _mint(to, currency, amount);
+        }
     }
 
     /// @inheritdoc IVault
@@ -156,8 +160,10 @@ contract Vault is IVault, VaultToken, Ownable {
         /// @notice settle all outstanding debt if amount is 0
         /// It will revert if target has negative delta
         if (amount == 0) amount = SettlementGuard.getCurrencyDelta(target, currency).toUint256();
-        SettlementGuard.accountDelta(msg.sender, currency, amount.toInt128());
-        SettlementGuard.accountDelta(target, currency, -(amount.toInt128()));
+        unchecked {
+            SettlementGuard.accountDelta(msg.sender, currency, amount.toInt128());
+            SettlementGuard.accountDelta(target, currency, -(amount.toInt128()));
+        }
     }
 
     /// @inheritdoc IVault