NFT marketplace V2 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aj-maz
requested review from
chefpickle,
ChefCupcake and
Chef-Cheems
as code owners
|
Hey guys, I was very busy these weeks and I did not make time to complete what was in my mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's my first commit to completing the Pancake swap bounty at the revelation hackathon.
I have created a version 2 marketplace based on the v1 and its tests. Added the Cake as a payment method.
In the constructor, the deployer specifies the Cake contract address + cake min price + cake max price.
Added an enum which is called currency which contains two currencies: BNB and Cake
Modified Ask struct to also have a currency property, also updated the events belonging to it.
Added another public function called buyTokenUsingCake which can be used for asks that are based on Cake.
Added a cakePendingRevenue which will be used for pending revenues based on the cake.
Updated _buyToken and claimPendingRevenue to act as expected.
Modified old tests to work with the current version, and also added new tests for new features.
==========
This is a work in progress. I will add offers and erc1155 in the coming days.
I'm also creating a new indexer here: https://github.com/Ajand/evm-nft-indexer
Since your old indexer was developed using java and I'm not a good java developer, the old one needed HUGE changes to be useable for the new marketplace, since you need dynamic collections and the ability to index erc1155, I'm creating a new one from scratch.