Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feat/pcsx jan 10 orbs #11135

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feat: feat/pcsx jan 10 orbs #11135

wants to merge 5 commits into from

Conversation

chef-ryan
Copy link
Contributor

@chef-ryan chef-ryan commented Jan 14, 2025


PR-Codex overview

This PR focuses on enhancing the ExclusiveDutchOrder structure and modifying various hooks and API interactions to improve quote handling and trading functionalities in the price API.

Detailed summary

  • Added quoteId property to ExclusiveDutchOrder.
  • Updated order.info.quoteId assignment in orderPriceApiParsers.ts.
  • Modified useAllTypeBestTrade to handle better quotes.
  • Changed X_API_ENDPOINT to a fixed URL in endpoints.ts.
  • Refactored useBestTradeFromApi to simplify its logic and remove shadowing.
  • Introduced new utility functions for fetching and parsing AMM prices.
  • Removed unused imports and functions to clean up the code.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Jan 14, 2025

⚠️ No Changeset found

Latest commit: 2280d9d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 1:16am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:16am
blog ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:16am
bridge ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:16am
games ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:16am
gamification ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:16am
uikit ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:16am
ton ⬜️ Skipped (Inspect) Jan 17, 2025 1:16am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant