Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Feat/pcsx jan 10 elfomo #11134

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

chef-ryan
Copy link
Contributor

@chef-ryan chef-ryan commented Jan 14, 2025


PR-Codex overview

This PR focuses on enhancing the ExclusiveDutchOrder class and related functionalities within the price API SDK. It introduces a new quoteId property, modifies order handling logic, and updates API endpoints for fetching trade data.

Detailed summary

  • Added quoteId property to ExclusiveDutchOrder.
  • Updated order.info.quoteId assignment in orderPriceApiParsers.ts.
  • Changed X_API_ENDPOINT to a fixed URL in endpoints.ts.
  • Modified betterQuote logic in useAllTypeBestTrade.ts.
  • Removed shadow API fetching logic in useBestTradeFromApi.ts.
  • Introduced new fetch functions for price API in useBestAMMTrade.ts.
  • Updated error handling and response parsing for API calls.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 1:12am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:12am
blog ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:12am
bridge ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:12am
games ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:12am
gamification ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:12am
uikit ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2025 1:12am
ton ⬜️ Skipped (Inspect) Jan 17, 2025 1:12am

Copy link

changeset-bot bot commented Jan 17, 2025

⚠️ No Changeset found

Latest commit: 1df39bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant