fix: Is wrong network modal persists when going back #11108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce:
Go to liqudity positions
Go to details of a position with different chain
See wrong network modal
Without switching chain go back, and see modal still displayed
PR-Codex overview
This PR updates the
useLocalNetworkChain
function in theuseActiveChainId.ts
file to improve the handling of thechainId
based on the readiness of the router. It ensures that thesetQueryChainId
is only called when necessary.Detailed summary
isReady
fromuseRouter()
to check if the router is ready.chainId
only ifisReady
is true.queryChainId
only if it differs fromchainId
.useEffect
hook to includeisReady
andqueryChainId
.isChainSupported
to ensurechainId
is defined before checking support.