Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Crash when multiple chains in url #11074

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Dec 19, 2024


PR-Codex overview

This PR focuses on improving the getChainId function to handle both string and array inputs for chainName. It also simplifies the retrieval of chainId from the query object in the useActiveChainId hook.

Detailed summary

  • Modified the chainId assignment in useActiveChainId to remove type casting from query.chain.
  • Updated getChainId to accept chainName as a string, string array, or undefined.
  • Added logic to handle input as an array in getChainId.
  • Enhanced memoization in getChainId for better performance.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 19, 2024

⚠️ No Changeset found

Latest commit: 5b4f17b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 0:09am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Dec 19, 2024 0:09am
blog ⬜️ Ignored (Inspect) Dec 19, 2024 0:09am
bridge ⬜️ Ignored (Inspect) Dec 19, 2024 0:09am
games ⬜️ Ignored (Inspect) Dec 19, 2024 0:09am
gamification ⬜️ Ignored (Inspect) Dec 19, 2024 0:09am
uikit ⬜️ Ignored (Inspect) Dec 19, 2024 0:09am
ton ⬜️ Skipped (Inspect) Dec 19, 2024 0:09am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant