Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Switch theme issue deps #11069

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Dec 18, 2024


PR-Codex overview

This PR focuses on updating the version specifications for several dependencies, particularly @babel/core, across multiple package.json files and the pnpm-lock.yaml file. The changes ensure consistency in dependency versions used throughout the project.

Detailed summary

  • Updated @babel/core version from ^7.23.9 to 7.23.9 in:
    • packages/hooks/package.json
    • packages/uikit/package.json
  • Adjusted @babel/preset-env and @babel/preset-react versions to 7.23.3 in various places.
  • Ensured consistency in pnpm-lock.yaml for dependencies related to @babel/core and others.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aptos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:44am
blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:44am
bridge ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:44am
games ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:44am
gamification ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:44am
ton 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:44am
uikit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:44am
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 10:44am

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: d0ebc73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Environment variable access npm/@testing-library/[email protected] 🚫
Deprecated npm/@types/[email protected]
  • Reason: This is a stub types definition for bignumber.js (https://github.com/MikeMcl/bignumber.js/). bignumber.js provides its own type definitions, so you don't need @types/bignumber.js installed!
🚫
Environment variable access npm/@testing-library/[email protected] 🚫
Environment variable access npm/@testing-library/[email protected] 🚫
Environment variable access npm/@testing-library/[email protected] 🚫
Environment variable access npm/@tanstack/[email protected] 🚫
Filesystem access npm/@typechain/[email protected] 🚫
Filesystem access npm/@typechain/[email protected] 🚫
Environment variable access npm/@tinyhttp/[email protected] 🚫
Filesystem access npm/@tinyhttp/[email protected] 🚫
Filesystem access npm/@tinyhttp/[email protected] 🚫
Filesystem access npm/@typechain/[email protected] 🚫
Filesystem access npm/[email protected] 🚫
Filesystem access npm/[email protected] 🚫
Filesystem access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/[email protected] 🚫
Environment variable access npm/@tanstack/[email protected] 🚫

View full report↗︎

Next steps

What is environment variable access?

Package accesses environment variables, which may be a sign of credential stuffing or data theft.

Packages should be clear about which environment variables they access, and care should be taken to ensure they only access environment variables they claim to.

What is a deprecated package?

The maintainer of the package marked it as deprecated. This could indicate that a single version should not be used, or that the package is no longer maintained and any new vulnerabilities will not be fixed.

Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

What is filesystem access?

Accesses the file system, and could potentially read sensitive data.

If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@Chef-Yogi Chef-Yogi merged commit d66dd00 into develop Dec 18, 2024
19 of 20 checks passed
@Chef-Yogi Chef-Yogi deleted the feature/fix_switch_theme_issue_deps branch December 18, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants