Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Fix Arguments passing order of usePoolTickData #11067

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

chef-ryan
Copy link
Contributor

@chef-ryan chef-ryan commented Dec 18, 2024


PR-Codex overview

This PR focuses on refactoring the useAllV3Ticks function calls across multiple components to utilize an object parameter instead of individual arguments, improving code readability and maintainability.

Detailed summary

  • Updated useAllV3Ticks calls in FarmV3ApyButton.tsx to use an object parameter.
  • Refactored useAllV3Ticks in AprCalculator.tsx similarly.
  • Changed useAllV3Ticks in V3PoolAprModal.tsx to accept an object parameter.
  • Modified the useAllV3Ticks function definition to accept an object with optional properties.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: d10354e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 6:09am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 6:09am
blog ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 6:09am
bridge ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 6:09am
games ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 6:09am
gamification ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 6:09am
uikit ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 6:09am
ton ⬜️ Skipped (Inspect) Dec 18, 2024 6:09am

thechefpenguin
thechefpenguin previously approved these changes Dec 18, 2024
Chef-Yogi
Chef-Yogi previously approved these changes Dec 18, 2024
memoyil
memoyil previously approved these changes Dec 18, 2024
@memoyil memoyil dismissed stale reviews from Chef-Yogi, thechefpenguin, and themself via 8064709 December 18, 2024 05:47
@vercel vercel bot temporarily deployed to Preview – ton December 18, 2024 05:47 Inactive
memoyil
memoyil previously approved these changes Dec 18, 2024
@vercel vercel bot temporarily deployed to Preview – web December 18, 2024 05:52 Inactive
@Chef-Yogi Chef-Yogi merged commit aff6d92 into develop Dec 18, 2024
20 checks passed
@Chef-Yogi Chef-Yogi deleted the fix/args_order_pooltickhook branch December 18, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants