Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mev toggle display logic #11061

Merged
merged 3 commits into from
Dec 19, 2024
Merged

fix: mev toggle display logic #11061

merged 3 commits into from
Dec 19, 2024

Conversation

Chef-Yogi
Copy link
Contributor

@Chef-Yogi Chef-Yogi commented Dec 17, 2024


PR-Codex overview

This PR enhances the useIsMEVEnabled hook by adding the isMEVProtectAvailable property and updates the useShouldShowMEVToggle hook to incorporate this new property in its return condition.

Detailed summary

  • Added isMEVProtectAvailable to the return object of the useIsMEVEnabled hook.
  • Updated useShouldShowMEVToggle to include isMEVProtectAvailable in its return condition.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 17, 2024

⚠️ No Changeset found

Latest commit: fc8e87d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 7:12am
7 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 7:12am
blog ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 7:12am
bridge ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 7:12am
games ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 7:12am
gamification ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 7:12am
uikit ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 7:12am
ton ⬜️ Skipped (Inspect) Dec 18, 2024 7:12am

memoyil
memoyil previously approved these changes Dec 17, 2024
apps/web/src/views/Mev/hooks/index.ts Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – ton December 18, 2024 07:03 Inactive
@Chef-Yogi Chef-Yogi merged commit 96ba8e0 into develop Dec 19, 2024
20 checks passed
@Chef-Yogi Chef-Yogi deleted the fix/mev-toggle-display-logic branch December 19, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants