Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase decimals on vecake card #10932

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

memoyil
Copy link
Collaborator

@memoyil memoyil commented Nov 9, 2024


PR-Codex overview

This PR focuses on renaming the lastTokenTimestamp variable to lastDistributionTimestamp across multiple files, reflecting a clearer representation of its purpose. Additionally, it updates the decimal precision for displayed values in the CakeRewardsCard.

Detailed summary

  • Renamed lastTokenTimestamp to lastDistributionTimestamp in:
    • RevenueSharing.tsx
    • useRevenueSharingProxy.ts
    • useRevenueSharingPool.ts
    • CakeRewardsCard.tsx
  • Updated decimal precision from 2 to 5 in CakeRewardsCard for various displayed values.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Nov 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2024 10:19am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
aptos-web ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2024 10:19am
blog ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2024 10:19am
bridge ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2024 10:19am
games ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2024 10:19am
gamification ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2024 10:19am
uikit ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2024 10:19am

availableClaim: claimResult.result.toString(),
}
} catch (error) {
console.error('[ERROR] Fetching Revenue Sharing Pool', error)
return initialData
throw error
Copy link
Collaborator Author

@memoyil memoyil Nov 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to retry if it fails

@@ -56,25 +58,24 @@ export const useRevenueSharingProxy = (
const [revenueResult, claimResult] = await Promise.all([
client.multicall({
contracts: revenueCalls,
allowFailure: true,
allowFailure: false,
Copy link
Collaborator Author

@memoyil memoyil Nov 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throw error if call fails that can be retried

Copy link

changeset-bot bot commented Nov 9, 2024

⚠️ No Changeset found

Latest commit: 078dc8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant